Reviewers: Erik Corry, Søren Gjesse, Mads Ager,
Message:
This patch removes the V8_NATIVE_REGEXP flag from codegen-arm.cc and
replaces it
with the V8_INTERPRETED_REGEXP to make the behavior consistent with the
rest of
the ARM code (as well as the ia32/x64 code).
Description:
Modified codegen-arm.cc to no longer use V8_NATIVE_REGEXP, but to use
V8_INTERPRETED_REGEXP (as per Issue 1635001).
BUG=none
TEST=Ran v8 tests, as well as against current Chromium browser.
Please review this at http://codereview.chromium.org/2078005/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm.cc
Index: src/arm/codegen-arm.cc
===================================================================
--- src/arm/codegen-arm.cc (revision 4643)
+++ src/arm/codegen-arm.cc (working copy)
@@ -8562,9 +8562,9 @@
// Just jump directly to runtime if native RegExp is not selected at
compile
// time or if regexp entry in generated code is turned off runtime
switch or
// at compilation.
-#ifndef V8_NATIVE_REGEXP
+#ifdef V8_INTERPRETED_REGEXP
__ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
-#else // V8_NATIVE_REGEXP
+#else // V8_INTERPRETED_REGEXP
if (!FLAG_regexp_entry_native) {
__ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
return;
@@ -8897,7 +8897,7 @@
// Do the runtime call to execute the regexp.
__ bind(&runtime);
__ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
-#endif // V8_NATIVE_REGEXP
+#endif // V8_INTERPRETED_REGEXP
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
