Reviewers: iposva,
Description:
Fix dtoa for the LP64 model on 64-bit systems, where long is 64 bits.
dtoa.c:69 states: #define Long int on machines with 32-bit ints and 64-bit
longs. This change was made in Chromium's version of dtoa in r21901. I don't
know why this apparently hasn't caused a problem in v8 until now. I was
unable to build a snapshot on x86_64 Mac without this change.
BUG=706
TEST=x86_64 Mac GYP/Xcode-based Chromium build (still depends on other
changes)
Please review this at http://codereview.chromium.org/2106007/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/third_party/dtoa/dtoa.c
Index: src/third_party/dtoa/dtoa.c
===================================================================
--- src/third_party/dtoa/dtoa.c (revision 4656)
+++ src/third_party/dtoa/dtoa.c (working copy)
@@ -164,8 +164,12 @@
*/
#ifndef Long
+#if __LP64__
+#define Long int
+#else
#define Long long
#endif
+#endif
#ifndef ULong
typedef unsigned Long ULong;
#endif
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
