http://codereview.chromium.org/2004006/diff/5001/6003#newcode103
src/flag-definitions.h:103: DEFINE_bool(push_pop_elimination, true,
Why do we still need this?
I preferred to keep both the flags, since "push_pop_elimination"
distinguishes
the patterns that leads to removal of the push/pops or replacement by a
register
copy. Infact one of the sets under "peephole_optimization" is now instead
triggered by "push_pop_elimination", since it actually deals with removing
the
push & pops, though is accociated with the "fp+offset" loads.
The "peephole_optimization" can be used for those class of patterns that
does
not relate to optimizing the push/pops. Right now we have one such class
that
deals with optimiszing the "fp+offset" load/stores. Maybe these (other than
push/pops) can be categorized as "memory_access_patterns"? or maybe just
leave
as peephole optimization as it is now.
http://codereview.chromium.org/2004006/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
