LGTM
http://codereview.chromium.org/2132005/diff/2001/3002 File src/heap.cc (right): http://codereview.chromium.org/2132005/diff/2001/3002#newcode649 src/heap.cc:649: if (MarkCompactCollector::IsCompacting()) { Seems like a left-over change since this just unconditionally increments mc_count_. http://codereview.chromium.org/2132005/diff/2001/3003 File src/heap.h (right): http://codereview.chromium.org/2132005/diff/2001/3003#newcode1647 src/heap.h:1647: explicit Scope(GCTracer* tracer, ScopeId scope) You can remove |explicit| now. http://codereview.chromium.org/2132005/diff/2001/3003#newcode1740 src/heap.h:1740: int start_holes_; |start_holes_| doesn't really capture what the comment is saying. How about: in_free_list_or_wasted_? http://codereview.chromium.org/2132005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
