http://codereview.chromium.org/2123005/diff/1/2 File src/api.cc (right):
http://codereview.chromium.org/2123005/diff/1/2#newcode63 src/api.cc:63: if (IsDeadCheck(location) || i::V8::ExecutionWasTerminated()) { \ I'm not sure I like making this check more expensive. This will not show up on pure JS benchmarks, but it will probably show up on DOM manipulation benchmarks where the API is used heavily. We should measure the impact on some of those as well. http://codereview.chromium.org/2123005/diff/1/5 File src/v8.h (right): http://codereview.chromium.org/2123005/diff/1/5#newcode120 src/v8.h:120: static bool execution_was_terminated_; Instead of using this separate boolean, you should perform the same check as IsExecutionTerminating. In this change, it seems that you do not allow any calls into V8 after a call to TerminateExecution at all (you never reset this boolean to false?). http://codereview.chromium.org/2123005/diff/1/6 File test/cctest/test-thread-termination.cc (right): http://codereview.chromium.org/2123005/diff/1/6#newcode349 test/cctest/test-thread-termination.cc:349: CHECK(!v8::V8::IsExecutionTerminating()); You should check that after attempting re-entry, you can still use V8 and get meaningful results when v8::V8::IsExecutionTerminating returns false. http://codereview.chromium.org/2123005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
