Reviewers: Søren Gjesse, prybin_chromium.org, Description: Fix buffer overflow in liveedit.
Make sure that there is always room for RelocInfoWriter::kMaxSize bytes in the buffer before writing to it. We only ensured space for 8 bytes, but relocation information can be up to 16 bytes in x64. Please review this at http://codereview.chromium.org/2100010/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/liveedit.cc Index: src/liveedit.cc =================================================================== --- src/liveedit.cc (revision 4681) +++ src/liveedit.cc (working copy) @@ -988,7 +988,7 @@ byte* buffer_; int buffer_size_; - static const int kBufferGap = 8; + static const int kBufferGap = RelocInfoWriter::kMaxSize; static const int kMaximalBufferSize = 512*MB; }; -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
