Revision: 4683 Author: [email protected] Date: Thu May 20 01:59:36 2010 Log: Fix buffer overflow in liveedit.
Make sure that there is always room for RelocInfoWriter::kMaxSize bytes in the buffer before writing to it. We only ensured space for 8 bytes, but relocation information can be up to 16 bytes in x64. Review URL: http://codereview.chromium.org/2100010 http://code.google.com/p/v8/source/detail?r=4683 Modified: /branches/bleeding_edge/src/liveedit.cc ======================================= --- /branches/bleeding_edge/src/liveedit.cc Tue May 4 06:07:36 2010 +++ /branches/bleeding_edge/src/liveedit.cc Thu May 20 01:59:36 2010 @@ -988,7 +988,7 @@ byte* buffer_; int buffer_size_; - static const int kBufferGap = 8; + static const int kBufferGap = RelocInfoWriter::kMaxSize; static const int kMaximalBufferSize = 512*MB; }; -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
