http://codereview.chromium.org/2123012/diff/5001/6005 File src/objects.cc (right):
http://codereview.chromium.org/2123012/diff/5001/6005#newcode2935 src/objects.cc:2935: if (result.IsProperty() && (result.IsReadOnly() || result.IsDontDelete())) { I think this requires a better comment. I still can't make sense of this only based on the comment below. After talking to Rico about this, I agree that this is the right thing to do because we are treating these API accessors as ES5 accessors. According to ES5, it is not allowed to overwrite any non-configurable (DONT_DELETE) property with an accessor. I think you need to make this part of the comment with a reference to the relevant part of ES5. http://codereview.chromium.org/2123012/diff/5001/6005#newcode6042 src/objects.cc:6042: Handle<Object> holder_handle(holder); This is not GC safe since the holder is wrapped in a handle *after* the call to NewNumberFromUint. http://codereview.chromium.org/2123012/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
