LGTM with comments.
http://codereview.chromium.org/2159002/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2159002/diff/1/2#newcode4059 src/arm/codegen-arm.cc:4059: VirtualFrame::SpilledScope spilled_scope(frame_); I think it would be better to spill after the two loads. That way you might be able to spill both registers in one instruction, and in the long term the spilled scope is going away, and SpillAll better reflects what we need to do here. http://codereview.chromium.org/2159002/diff/1/2#newcode5046 src/arm/codegen-arm.cc:5046: LoadCondition(node->left(), &is_true, false_target(), false); I'm a bit worried about this function. I have some bug fixes in the pipeline to JumpTargets and virtual frames and I'm not sure you can do this without out them. http://codereview.chromium.org/2159002/diff/1/2#newcode5101 src/arm/codegen-arm.cc:5101: frame_->EmitPop(r0); This is only OK if you know that r0 is free. I can't see how you know that. http://codereview.chromium.org/2159002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
