Mads I also decided to tweak NewSpace::Contains(Object*), SemiSpace::Contains(Object*) to make them match their contract.
Please take a look. http://codereview.chromium.org/2144006/diff/4001/5028 File src/spaces.cc (left): http://codereview.chromium.org/2144006/diff/4001/5028#oldcode1124 src/spaces.cc:1124: object_expected_ = reinterpret_cast<uintptr_t>(start) | kHeapObjectTag; Change object_mask_ to match HasHeapObjectTag() implementation. Contains(Object*) should return true iff IsHeapObject() returns true http://codereview.chromium.org/2144006/diff/4001/5028#oldcode1328 src/spaces.cc:1328: object_expected_ = reinterpret_cast<uintptr_t>(start) | kHeapObjectTag; Change object_mask_ to match HasHeapObjectTag() implementation. Contains(Object*) should return true iff IsHeapObject() returns true. http://codereview.chromium.org/2144006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
