http://codereview.chromium.org/2163006/diff/10001/11002 File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/2163006/diff/10001/11002#newcode919 src/arm/full-codegen-arm.cc:919: __ push(r2); // Enumeration cache. On 2010/05/25 12:55:25, Erik Corry wrote:
Move this push down two instructions and you can do a multi-register
push and
get more code density?
Done. http://codereview.chromium.org/2163006/diff/10001/11002#newcode920 src/arm/full-codegen-arm.cc:920: __ ldr(r0, FieldMemOperand(r2, FixedArray::kLengthOffset)); On 2010/05/25 12:55:25, Erik Corry wrote:
And make this r1 so you can do 3 pushes in one?
Done. http://codereview.chromium.org/2163006/diff/10001/11002#newcode931 src/arm/full-codegen-arm.cc:931: __ ldr(r0, FieldMemOperand(r0, FixedArray::kLengthOffset)); On 2010/05/25 12:55:25, Erik Corry wrote:
And make this r1 so you can push 2 in one?
Done. http://codereview.chromium.org/2163006/diff/10001/11002#newcode1071 src/arm/full-codegen-arm.cc:1071: __ LoadRoot(ip, Heap::kUndefinedValueRootIndex); On 2010/05/25 12:55:25, Erik Corry wrote:
Why not just load this directly into r0?
Done. http://codereview.chromium.org/2163006/diff/10001/11002#newcode1713 src/arm/full-codegen-arm.cc:1713: __ str(r1, MemOperand(sp, arg_count * kPointerSize)); On 2010/05/25 12:55:25, Erik Corry wrote:
Is this strd or am I getting it back to front?
strd puts r0 in lowest memory, so it is not applicable here. http://codereview.chromium.org/2163006/diff/10001/11002#newcode2174 src/arm/full-codegen-arm.cc:2174: __ mov(r0, Operand(Factory::function_class_symbol())); On 2010/05/25 12:55:25, Erik Corry wrote:
There's a root for that (two places).
Done. http://codereview.chromium.org/2163006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
