Reviewers: Erik Corry,

Description:
ARM: Default to use unaligned accesses in the simulator

This removes the requirement of defining CAN_USE_UNALIGNED_ACCESSES to 1 when
building the simulator.

Please review this at http://codereview.chromium.org/2218003/show

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     SConstruct
  M     src/arm/constants-arm.h


Index: SConstruct
===================================================================
--- SConstruct  (revision 4723)
+++ SConstruct  (working copy)
@@ -207,7 +207,7 @@
       'CPPDEFINES':   ['V8_TARGET_ARCH_ARM']
     },
     'simulator:arm': {
-      'CCFLAGS':      ['-m32', '-DCAN_USE_UNALIGNED_ACCESSES=1'],
+      'CCFLAGS':      ['-m32'],
       'LINKFLAGS':    ['-m32']
     },
     'arch:mips': {
Index: src/arm/constants-arm.h
===================================================================
--- src/arm/constants-arm.h     (revision 4723)
+++ src/arm/constants-arm.h     (working copy)
@@ -66,10 +66,11 @@
 # define CAN_USE_THUMB_INSTRUCTIONS 1
 #endif

-// Simulator should support ARM5 instructions.
+// Simulator should support ARM5 instructions and unaligned access.
 #if !defined(__arm__)
 # define CAN_USE_ARMV5_INSTRUCTIONS 1
 # define CAN_USE_THUMB_INSTRUCTIONS 1
+# define CAN_USE_UNALIGNED_ACCESSES 1
 #endif

 #if CAN_USE_UNALIGNED_ACCESSES


--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to