http://codereview.chromium.org/2278002/diff/7001/8001 File src/runtime.cc (right):
http://codereview.chromium.org/2278002/diff/7001/8001#newcode589 src/runtime.cc:589: GetOwnPropertyImplementation(obj, name, &result); Maybe do the split before? Start out checking if the name is really an array index and avoid this call if it is? http://codereview.chromium.org/2278002/diff/7001/8001#newcode594 src/runtime.cc:594: if (!name->AsArrayIndex(&index) || !obj->HasElement(index)) { Does HasElement do the right thing? Shouldn't you use HasLocalElement? http://codereview.chromium.org/2278002/diff/7001/8001#newcode603 src/runtime.cc:603: // Since we already did a check earlier on that we actually have the Since we already checked that we have an element there is no need to check if the entry is valid. http://codereview.chromium.org/2278002/diff/7001/8001#newcode606 src/runtime.cc:606: elms->set(0, Heap::false_value()); Maybe we should define named constants for 0-4. Would make it easier to read the code for property descriptors. http://codereview.chromium.org/2278002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
