LGTM
http://codereview.chromium.org/2249002/diff/10002/12001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2249002/diff/10002/12001#newcode5421 src/arm/codegen-arm.cc:5421: void DeferredReferenceGetNamedValue::Generate() { Maybe add the expected height assert as in other functions. http://codereview.chromium.org/2249002/diff/10002/12001#newcode5425 src/arm/codegen-arm.cc:5425: ASSERT(receiver_.is(r0) || receiver_.is(r1)); Maybe we should have an AssertIsTOSRegister. http://codereview.chromium.org/2249002/diff/10002/12001#newcode5620 src/arm/codegen-arm.cc:5620: deferred->BindExit(); This deserves a comment saying that the receiver register now has the result. http://codereview.chromium.org/2249002/diff/10002/12001#newcode5867 src/arm/codegen-arm.cc:5867: if (!persist_after_get_) { This is nasty. Shouldn't we aim at getting rid of References? http://codereview.chromium.org/2249002/diff/10002/12006 File src/arm/virtual-frame-arm.cc (right): http://codereview.chromium.org/2249002/diff/10002/12006#newcode166 src/arm/virtual-frame-arm.cc:166: if (cond == al) { This relies on the fact that the frame is only merged on backward branches? http://codereview.chromium.org/2249002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
