LGTM.
http://codereview.chromium.org/2266003/diff/1/3 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2266003/diff/1/3#newcode11079 src/x64/codegen-x64.cc:11079: // boundary before starting rep movs. Copy remaining characters after running Where is the destination aligned to a 4-byte boundary before rep movs? http://codereview.chromium.org/2266003/diff/1/5 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/2266003/diff/1/5#newcode577 src/x64/macro-assembler-x64.cc:577: movl(dst, Operand(src, kIntSize)); Is kIntSize really better than "4" here? If anything ever changes, there is no reason to think kIntSize will remain the correct value. http://codereview.chromium.org/2266003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
