I have inlined the functions LoadInterceptorCompiler::CompileCacheable and
LoadInterceptorCompiler::CompileRegular into the templated function
CompileLoadInterceptor, and inlined CompileLoadInterceptor into
GenerateLoadInterceptor.
Then I removed the unused class LoadInterceptorCompiler and unused templated
function CompileLoadInterceptor.
I think the result is still clear, and easy to read and understand. I will
edit
this change list to have a more descriptive name, and add the other
platforms to
it.
http://codereview.chromium.org/2251003/diff/1/2
File src/ia32/stub-cache-ia32.cc (right):
http://codereview.chromium.org/2251003/diff/1/2#newcode328
src/ia32/stub-cache-ia32.cc:328: void Compile() {
I don't understand the comment.
On 2010/05/26 16:19:41, antonm wrote:
given compile doesn't accept any parameters, maybe it's time to turn
it inot a
function?
http://codereview.chromium.org/2251003/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
