Revision: 4740
Author: [email protected]
Date: Thu May 27 04:16:04 2010
Log: Move assertions to not take case to check that it's safe to omit
CheckPrototypes in this case.
Review URL: http://codereview.chromium.org/2279005
http://code.google.com/p/v8/source/detail?r=4740
Modified:
/branches/bleeding_edge/src/arm/stub-cache-arm.cc
/branches/bleeding_edge/src/ia32/stub-cache-ia32.cc
/branches/bleeding_edge/src/x64/stub-cache-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/stub-cache-arm.cc Wed May 26 07:23:19
2010
+++ /branches/bleeding_edge/src/arm/stub-cache-arm.cc Thu May 27 04:16:04
2010
@@ -789,11 +789,12 @@
stub_compiler_->CheckPrototypes(interceptor_holder, receiver,
lookup->holder(), scratch1,
scratch2, name, depth2, miss);
+ } else {
// CheckPrototypes has a side effect of fetching a 'holder'
// for API (object which is instanceof for the signature). It's
// safe to omit it here, as if present, it should be fetched
// by the previous CheckPrototypes.
- ASSERT((depth2 == kInvalidProtoDepth) || (depth1 !=
kInvalidProtoDepth));
+ ASSERT(depth2 == kInvalidProtoDepth);
}
// Invoke function.
=======================================
--- /branches/bleeding_edge/src/ia32/stub-cache-ia32.cc Wed May 26 07:23:19
2010
+++ /branches/bleeding_edge/src/ia32/stub-cache-ia32.cc Thu May 27 04:16:04
2010
@@ -687,11 +687,12 @@
stub_compiler_->CheckPrototypes(interceptor_holder, receiver,
lookup->holder(), scratch1,
scratch2, name, depth2, miss);
+ } else {
// CheckPrototypes has a side effect of fetching a 'holder'
// for API (object which is instanceof for the signature). It's
// safe to omit it here, as if present, it should be fetched
// by the previous CheckPrototypes.
- ASSERT((depth2 == kInvalidProtoDepth) || (depth1 !=
kInvalidProtoDepth));
+ ASSERT(depth2 == kInvalidProtoDepth);
}
// Invoke function.
=======================================
--- /branches/bleeding_edge/src/x64/stub-cache-x64.cc Wed May 26 07:23:19
2010
+++ /branches/bleeding_edge/src/x64/stub-cache-x64.cc Thu May 27 04:16:04
2010
@@ -763,11 +763,12 @@
stub_compiler_->CheckPrototypes(interceptor_holder, receiver,
lookup->holder(), scratch1,
scratch2, name, depth2, miss);
+ } else {
// CheckPrototypes has a side effect of fetching a 'holder'
// for API (object which is instanceof for the signature). It's
// safe to omit it here, as if present, it should be fetched
// by the previous CheckPrototypes.
- ASSERT((depth2 == kInvalidProtoDepth) || (depth1 !=
kInvalidProtoDepth));
+ ASSERT(depth2 == kInvalidProtoDepth);
}
// Invoke function.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
