LGTM

http://codereview.chromium.org/2368001/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2368001/diff/1/2#newcode4058
src/arm/codegen-arm.cc:4058: Load(args->at(2));
Isn't SpillAll/AssertIsSpilled needed here? (I don't think %_Log is used
when running our tests though)

http://codereview.chromium.org/2368001/diff/1/2#newcode4519
src/arm/codegen-arm.cc:4519: frame_->SpillAll();
How about moving the SpillAll to CallStub?

http://codereview.chromium.org/2368001/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to