LGTM.
http://codereview.chromium.org/2435001/diff/1/28 File src/heap.cc (right): http://codereview.chromium.org/2435001/diff/1/28#newcode2163 src/heap.cc:2163: Object* value = HEAP->single_character_string_cache()->get(code); THIS? http://codereview.chromium.org/2435001/diff/1/28#newcode2171 src/heap.cc:2171: HEAP->single_character_string_cache()->set(code, result); THIS? http://codereview.chromium.org/2435001/diff/1/29 File src/heap.h (right): http://codereview.chromium.org/2435001/diff/1/29#newcode705 src/heap.h:705: inline type* name() { \ Strictly speaking you don't need "inline" here. http://codereview.chromium.org/2435001/diff/1/36 File src/isolate.cc (right): http://codereview.chromium.org/2435001/diff/1/36#newcode112 src/isolate.cc:112: old_global_isolate = global_isolate; Shouldn't it be the other way around? http://codereview.chromium.org/2435001/diff/1/37 File src/isolate.h (right): http://codereview.chromium.org/2435001/diff/1/37#newcode56 src/isolate.h:56: inline Heap* heap() { Same comment about "inline". You could also format this as a one-liner: Heap* heap() { return &heap_; } http://codereview.chromium.org/2435001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
