LGTM
http://codereview.chromium.org/2441002/diff/13001/4003 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/2441002/diff/13001/4003#newcode58 src/arm/ic-arm.cc:58: // The three scratch registers needs to be different from the receiver, name and registers needs -> registers need http://codereview.chromium.org/2441002/diff/13001/4003#newcode922 src/arm/ic-arm.cc:922: // there is no difference in using either key. Funky! http://codereview.chromium.org/2441002/diff/13001/4003#newcode924 src/arm/ic-arm.cc:924: __ jmp(&index_smi); I think here and at the destination there should be a comment with what is expected to be in which register. http://codereview.chromium.org/2441002/diff/13001/4004 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/2441002/diff/13001/4004#newcode411 src/ia32/ic-ia32.cc:411: // ecx: key map Full stop. http://codereview.chromium.org/2441002/diff/13001/4004#newcode491 src/ia32/ic-ia32.cc:491: // eax: key (string) Full stops. http://codereview.chromium.org/2441002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
