Revision: 4785
Author: [email protected]
Date: Wed Jun  2 04:05:06 2010
Log: Fix bug in test case that made it fail to compile in non-debug mode.
Using ASSERT_EQ instead of CHECK_EQ means that a variable becomes unused.

Review URL: http://codereview.chromium.org/2475003
http://code.google.com/p/v8/source/detail?r=4785

Modified:
 /branches/bleeding_edge/test/cctest/test-strings.cc

=======================================
--- /branches/bleeding_edge/test/cctest/test-strings.cc Wed Jun 2 02:31:01 2010 +++ /branches/bleeding_edge/test/cctest/test-strings.cc Wed Jun 2 04:05:06 2010
@@ -473,11 +473,11 @@
     printf("%s\n", line);
     v8::Local<v8::Value> result =
         v8::Script::Compile(v8::String::New(line))->Run();
-    ASSERT_EQ(results[i]->IsUndefined(), result->IsUndefined());
-    ASSERT_EQ(results[i]->IsNumber(), result->IsNumber());
+    CHECK_EQ(results[i]->IsUndefined(), result->IsUndefined());
+    CHECK_EQ(results[i]->IsNumber(), result->IsNumber());
     if (result->IsNumber()) {
-      ASSERT_EQ(Smi::cast(results[i]->ToSmi())->value(),
-                result->ToInt32()->Value());
+      CHECK_EQ(Smi::cast(results[i]->ToSmi())->value(),
+               result->ToInt32()->Value());
     }
   }
 }

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to