LGTM
http://codereview.chromium.org/2470001/diff/13/22004 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2470001/diff/13/22004#newcode7599 src/x64/codegen-x64.cc:7599: if (persist_after_get_) { On ARM Dup2 duplicated the top two elements on the stack. You should be able to use cgen_->frame()->PushElementAt(1); (twice) here instead. http://codereview.chromium.org/2470001/diff/13/22006 File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/2470001/diff/13/22006#newcode1827 src/x64/full-codegen-x64.cc:1827: __ movq(rdx, Operand(rsp, 0)); Can't you pop here... http://codereview.chromium.org/2470001/diff/13/22006#newcode1836 src/x64/full-codegen-x64.cc:1836: __ pop(rbx); ... and remove this pop. I don't see this popped receiver being used. http://codereview.chromium.org/2470001/diff/13/22007 File src/x64/ic-x64.cc (right): http://codereview.chromium.org/2470001/diff/13/22007#newcode358 src/x64/ic-x64.cc:358: // Load name and receiver. Code in comments. http://codereview.chromium.org/2470001/diff/13/22010 File src/x64/virtual-frame-x64.h (right): http://codereview.chromium.org/2470001/diff/13/22010#newcode390 src/x64/virtual-frame-x64.h:390: void Dup2() { PushFrameSlotAt(element_count() - 2); } In the ARM implementation Dup2 duplicates the top two elements on the stack. This is equivalent to PushElementAt(1); http://codereview.chromium.org/2470001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
