On Wed, Jun 2, 2010 at 6:39 PM, Vladislav Kaznacheev <[email protected]> wrote: > OK. BTW, similar change on x64 broke something, so I know it is not that > simple.
Yeah, nice thing about fixing the runtime function is that you don't have to touch the generated code all architectures. -- Vitaly > On Wed, Jun 2, 2010 at 6:36 PM, <[email protected]> wrote: >> >> Vlad, >> >> Thanks a lot for spotting this! >> >> Unfortunately, you can't just overwrite the index register. The contract >> of the >> generator is to preserve it. It may fail depending on the state of the >> calling >> virtual frame. I think the right fix to change the runtime function, >> because it >> is only called from this code. I'm sending you a review with this fix (and >> some >> tests)... >> >> >> -- Vitaly >> >> http://codereview.chromium.org/2478003/show > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
