http://codereview.chromium.org/2450005/diff/9001/10001 File src/isolate.cc (right):
http://codereview.chromium.org/2450005/diff/9001/10001#newcode85 src/isolate.cc:85: Isolate::~Isolate() { Shouldn't we decrement number_of_isolates here? http://codereview.chromium.org/2450005/diff/9001/10002 File src/isolate.h (right): http://codereview.chromium.org/2450005/diff/9001/10002#newcode43 src/isolate.h:43: #define ISOLATE_INIT_ARRAY_LIST(V) \ Do you expect more of these guys? If not (or just a couple more), then consider removing the macro. http://codereview.chromium.org/2450005/diff/9001/10002#newcode48 src/isolate.h:48: V(bool, zone_allow_allocation, true) /* AssertNoZoneAllocation */ \ Put /* */ comments before the lines they describe to make the list readable. http://codereview.chromium.org/2450005/diff/9001/10002#newcode69 src/isolate.h:69: static void InitOnce(); nit: Please bring the blank line back. http://codereview.chromium.org/2450005/diff/9001/10002#newcode91 src/isolate.h:91: // SerializerDeserializer:: "::" -> " state." http://codereview.chromium.org/2450005/diff/9001/10003 File src/serialize.cc (right): http://codereview.chromium.org/2450005/diff/9001/10003#newcode605 src/serialize.cc:605: ASSERT_EQ(NULL, Isolate::Current()->serialize_external_reference_decoder()); ExternalReferenceDecoder should most likely be an instance field of Deserializer. Could check that? If it turns out to be true, please convert it. http://codereview.chromium.org/2450005/diff/9001/10004 File src/serialize.h (right): http://codereview.chromium.org/2450005/diff/9001/10004#newcode73 src/serialize.h:73: RLYSTC uint32_t Hash(Address key) { I think we should only use this nice macro for members of complex large classes (that are in process of being converted). We could use another marker of some sort to indicate that a class has been already converted. Dmitry proposes KTHXBYE_CLASS. http://codereview.chromium.org/2450005/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
