Comments addressed.
http://codereview.chromium.org/2586001/diff/1/4 File src/ia32/builtins-ia32.cc (right): http://codereview.chromium.org/2586001/diff/1/4#newcode616 src/ia32/builtins-ia32.cc:616: __ CmpObjectType(ebx, FIRST_JS_OBJECT_TYPE, ecx); On 2010/06/04 07:46:23, Lasse Reichstein wrote:
This seems to be comparing the instance type with a range, and not
using the
value after that. We should be able to reduce that to a single unsigned comparison and
jump. Could
we add a macro that did range-comparison, e.g., CmpObjectTypeRange(ebx, FIRST_JS_OBJECT_TYPE, LAST_JS_OBJECT_TYPE,
ecx)
where ecx is used as scratch (no guarantees on the value afterwards).
Done. http://codereview.chromium.org/2586001/diff/1/5 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/2586001/diff/1/5#newcode2735 src/ia32/codegen-ia32.cc:2735: // If the length is 0 then the subtraction gave -1, setting On 2010/06/04 07:46:23, Lasse Reichstein wrote:
Comment is out of sync (there is no longer a subtraction).
Done. http://codereview.chromium.org/2586001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
