Revision: 4798
Author: [email protected]
Date: Fri Jun 4 04:57:01 2010
Log: Rename ThreadManager::IterateThreads to
ThreadManager::IterateArchivedThreads
The IterateThreads method only iterates archived threads. If all
threads are to be iterated an additional iteration of the current active
stack is also needed.
Review URL: http://codereview.chromium.org/2655002
http://code.google.com/p/v8/source/detail?r=4798
Modified:
/branches/bleeding_edge/src/heap.cc
/branches/bleeding_edge/src/liveedit.cc
/branches/bleeding_edge/src/v8threads.cc
/branches/bleeding_edge/src/v8threads.h
=======================================
--- /branches/bleeding_edge/src/heap.cc Thu May 27 05:30:45 2010
+++ /branches/bleeding_edge/src/heap.cc Fri Jun 4 04:57:01 2010
@@ -560,7 +560,7 @@
void Heap::ClearJSFunctionResultCaches() {
if (Bootstrapper::IsActive()) return;
ClearThreadJSFunctionResultCachesVisitor visitor;
- ThreadManager::IterateThreads(&visitor);
+ ThreadManager::IterateArchivedThreads(&visitor);
}
=======================================
--- /branches/bleeding_edge/src/liveedit.cc Thu May 20 01:59:36 2010
+++ /branches/bleeding_edge/src/liveedit.cc Fri Jun 4 04:57:01 2010
@@ -794,7 +794,7 @@
static void IterateAllThreads(ThreadVisitor* visitor) {
Top::IterateThread(visitor);
- ThreadManager::IterateThreads(visitor);
+ ThreadManager::IterateArchivedThreads(visitor);
}
// Finds all references to original and replaces them with substitution.
@@ -1386,7 +1386,7 @@
// First check inactive threads. Fail if some functions are blocked
there.
InactiveThreadActivationsChecker
inactive_threads_checker(shared_info_array,
result);
- ThreadManager::IterateThreads(&inactive_threads_checker);
+ ThreadManager::IterateArchivedThreads(&inactive_threads_checker);
if (inactive_threads_checker.HasBlockedFunctions()) {
return result;
}
=======================================
--- /branches/bleeding_edge/src/v8threads.cc Sat Mar 20 15:37:15 2010
+++ /branches/bleeding_edge/src/v8threads.cc Fri Jun 4 04:57:01 2010
@@ -331,7 +331,7 @@
}
-void ThreadManager::IterateThreads(ThreadVisitor* v) {
+void ThreadManager::IterateArchivedThreads(ThreadVisitor* v) {
for (ThreadState* state = ThreadState::FirstInUse();
state != NULL;
state = state->Next()) {
=======================================
--- /branches/bleeding_edge/src/v8threads.h Sat Mar 20 15:37:15 2010
+++ /branches/bleeding_edge/src/v8threads.h Fri Jun 4 04:57:01 2010
@@ -104,7 +104,7 @@
static bool IsArchived();
static void Iterate(ObjectVisitor* v);
- static void IterateThreads(ThreadVisitor* v);
+ static void IterateArchivedThreads(ThreadVisitor* v);
static void MarkCompactPrologue(bool is_compacting);
static void MarkCompactEpilogue(bool is_compacting);
static bool IsLockedByCurrentThread() { return mutex_owner_.IsSelf(); }
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
