LGTM
http://codereview.chromium.org/2645004/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/2645004/diff/1/2#newcode1125 include/v8.h:1125: * resource. When the external string is no longer live on V8's heap and is Remove "and is collected"? http://codereview.chromium.org/2645004/diff/1/2#newcode1126 include/v8.h:1126: * collected the resource will be disposed either by delete called from the This explanation is a bit convoluted. How about: ... the resource will be disposed. If a disposal callback has been set using SetExternalStringDiposeCallback this callback will be called to dispose the resource. Otherwise, V8 will dispose the resource using the C++ delete operator. ? http://codereview.chromium.org/2645004/diff/1/2#newcode1149 include/v8.h:1149: * resource. When the external string is no longer live on V8's heap and is Ditto. http://codereview.chromium.org/2645004/diff/1/2#newcode1256 include/v8.h:1256: typedef void (*ExternalStringResourceCollectedCallback) How about "ExternalStringDisposeCallback"? http://codereview.chromium.org/2645004/diff/1/2#newcode2477 include/v8.h:2477: * Set a callback to be called when an external string external string is no Delete one occurrence of "external string". http://codereview.chromium.org/2645004/diff/1/2#newcode2480 include/v8.h:2480: * the the resource using the C++ delete operator. the the -> the http://codereview.chromium.org/2645004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
