LGTM
http://codereview.chromium.org/2701003/diff/3001/4001 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/2701003/diff/3001/4001#newcode838 src/arm/ic-arm.cc:838: __ b(eq, &index_string); Why change the value of the flag to zero=true? http://codereview.chromium.org/2701003/diff/3001/4005 File src/objects.h (right): http://codereview.chromium.org/2701003/diff/3001/4005#newcode4210 src/objects.h:4210: static const int kArrayIndexValueBits = This seems backwards. Define the bit count as constants, and calculate the shifts from those instead. http://codereview.chromium.org/2701003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
