LGTM
http://codereview.chromium.org/2700004/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/2700004/diff/1/2#newcode12599 src/ia32/codegen-ia32.cc:12599: ASSERT_EQ(0, kSeqStringTag); I prefer STATIC_ASSERT for checking constants. I don't know if there is a STATIC_ASSERT_EQ, though. http://codereview.chromium.org/2700004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
