LGTM with comments.
Thanks, Vitaly http://codereview.chromium.org/2658008/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/2658008/diff/1/2#newcode1029 include/v8.h:1029: /** nit: Insert a black line before the comment. http://codereview.chromium.org/2658008/diff/1/2#newcode1031 include/v8.h:1031: * disposed. I think we should add "The default implementation calls delete operator on this." so that users of the API can rely on this fact and don't have to call our Dispose. http://codereview.chromium.org/2658008/diff/1/7 File test/cctest/test-api.cc (right): http://codereview.chromium.org/2658008/diff/1/7#newcode619 test/cctest/test-api.cc:619: explicit TestAsciiResourceWithDisposeControl(const char* data, bool dispose) nit: "explicit" not required. http://codereview.chromium.org/2658008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
