On 2010/06/07 07:57:07, Mads Ager wrote:
This looks reasonable to me.
The issue here is that this entry point for pre-compilation will operate on
data
in the heap and therefore pre-compilation using this method cannot happen on another thread without using Lockers (you could add a comment about that to
the
API method). Maybe a better approach would be to create a UC16 API method for pre-compilation to avoid adding an API method operating on heap data to the
API.
However, I'm fine with adding this API method for now.
Sticking with this approach is the cleanest from the WebKit side. It could be easy to change if we need a UC16 for another reason. I've added the comment you
suggested and a test to exercise this variant of the API. http://codereview.chromium.org/2633004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
