LGTM, did you measure performance impact caused by this change?
http://codereview.chromium.org/2693002/diff/18001/19009 File src/assembler.h (right): http://codereview.chromium.org/2693002/diff/18001/19009#newcode250 src/assembler.h:250: // Check whether this return debug break slot has been patched typo: this return debug -> this debug http://codereview.chromium.org/2693002/diff/18001/19016 File src/debug.cc (right): http://codereview.chromium.org/2693002/diff/18001/19016#newcode1670 src/debug.cc:1670: addr - Assembler::kPatchReturnSequenceAddressOffset); should be kPatchDebugBreakSlotAddressOffset http://codereview.chromium.org/2693002/diff/18001/19016#newcode1697 src/debug.cc:1697: // address to jump to to complete the call which is replaced by a call to typo: to to -> to http://codereview.chromium.org/2693002/diff/18001/19019 File src/full-codegen.cc (right): http://codereview.chromium.org/2693002/diff/18001/19019#newcode522 src/full-codegen.cc:522: // Mark for statements breakable breakable if the condition expression is. breakable breakable -> breakable http://codereview.chromium.org/2693002/diff/18001/19019#newcode795 src/full-codegen.cc:795: if (position_recorded) { why test for !checker.is_breakable() wouldn't work here? http://codereview.chromium.org/2693002/diff/18001/19019#newcode809 src/full-codegen.cc:809: if (!Debugger::IsDebuggerActive()) { This piece of code mostly resembles the one above, consider extracting it in a method. http://codereview.chromium.org/2693002/diff/18001/19019#newcode832 src/full-codegen.cc:832: CodeGenerator::RecordPositions(masm_, stmt->statement_pos()); there is no stmt variable in this scope http://codereview.chromium.org/2693002/diff/18001/19020 File src/full-codegen.h (right): http://codereview.chromium.org/2693002/diff/18001/19020#newcode64 src/full-codegen.h:64: // that there will be an IC (loat/store/call) in the code generated for the typo: loat -> load http://codereview.chromium.org/2693002/diff/18001/19034 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/2693002/diff/18001/19034#newcode458 src/x64/assembler-x64.h:458: // Distance between start of patched debug break slot and and where the and and -> and http://codereview.chromium.org/2693002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
