Reviewers: Mads Ager, Description: Add parenthesis around '&&' within '||'
Warning by some gcc versions. Adding the parenthesis made the condition correct.
[email protected] Please review this at http://codereview.chromium.org/2725003/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/assembler-arm-inl.h M src/ia32/assembler-ia32-inl.h M src/x64/assembler-x64-inl.h Index: src/arm/assembler-arm-inl.h =================================================================== --- src/arm/assembler-arm-inl.h (revision 4820) +++ src/arm/assembler-arm-inl.h (working copy) @@ -184,10 +184,10 @@ visitor->VisitExternalReference(target_reference_address()); #ifdef ENABLE_DEBUGGER_SUPPORT } else if (Debug::has_break_points() && - (RelocInfo::IsJSReturn(mode) && + ((RelocInfo::IsJSReturn(mode) && IsPatchedReturnSequence()) || (RelocInfo::IsDebugBreakSlot(mode) && - IsPatchedDebugBreakSlotSequence())) { + IsPatchedDebugBreakSlotSequence()))) { visitor->VisitDebugTarget(this); #endif } else if (mode == RelocInfo::RUNTIME_ENTRY) { Index: src/ia32/assembler-ia32-inl.h =================================================================== --- src/ia32/assembler-ia32-inl.h (revision 4820) +++ src/ia32/assembler-ia32-inl.h (working copy) @@ -174,10 +174,10 @@ visitor->VisitExternalReference(target_reference_address()); #ifdef ENABLE_DEBUGGER_SUPPORT } else if (Debug::has_break_points() && - (RelocInfo::IsJSReturn(mode) && + ((RelocInfo::IsJSReturn(mode) && IsPatchedReturnSequence()) || (RelocInfo::IsDebugBreakSlot(mode) && - IsPatchedDebugBreakSlotSequence())) { + IsPatchedDebugBreakSlotSequence()))) { visitor->VisitDebugTarget(this); #endif } else if (mode == RelocInfo::RUNTIME_ENTRY) { Index: src/x64/assembler-x64-inl.h =================================================================== --- src/x64/assembler-x64-inl.h (revision 4820) +++ src/x64/assembler-x64-inl.h (working copy) @@ -350,10 +350,10 @@ visitor->VisitExternalReference(target_reference_address()); #ifdef ENABLE_DEBUGGER_SUPPORT } else if (Debug::has_break_points() && - (RelocInfo::IsJSReturn(mode) && + ((RelocInfo::IsJSReturn(mode) && IsPatchedReturnSequence()) || (RelocInfo::IsDebugBreakSlot(mode) && - IsPatchedDebugBreakSlotSequence())) { + IsPatchedDebugBreakSlotSequence()))) { visitor->VisitDebugTarget(this); #endif } else if (mode == RelocInfo::RUNTIME_ENTRY) { -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
