LGTM
http://codereview.chromium.org/2754003/diff/13001/12004 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/2754003/diff/13001/12004#newcode309 src/ia32/ic-ia32.cc:309: Register r0, r0 -> scratch or map? http://codereview.chromium.org/2754003/diff/13001/12004#newcode342 src/ia32/ic-ia32.cc:342: Register r0, r0 -> scratch? http://codereview.chromium.org/2754003/diff/13001/12004#newcode373 src/ia32/ic-ia32.cc:373: // Checks whether a key is an array index string or a symbol string. Could you add a comment that this generates code that falls through if the key is a symbol? http://codereview.chromium.org/2754003/diff/13001/12004#newcode383 src/ia32/ic-ia32.cc:383: // r0 - used to hold the map of the key. r0 -> map? http://codereview.chromium.org/2754003/diff/13001/12004#newcode384 src/ia32/ic-ia32.cc:384: // r1 - used to hold the hash of the key. r1 -> hash? http://codereview.chromium.org/2754003/diff/13001/12004#newcode400 src/ia32/ic-ia32.cc:400: // Picks out an array index from the hash field. Add a comment that the code generated never falls through? http://codereview.chromium.org/2754003/diff/13001/12004#newcode505 src/ia32/ic-ia32.cc:505: KeyedLoadIC::GenerateRuntimeGetProperty(masm); Is the KeyedLoadIC:: prefix needed? http://codereview.chromium.org/2754003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
