http://codereview.chromium.org/2722005/diff/5001/6002 File src/profile-generator.cc (right):
http://codereview.chromium.org/2722005/diff/5001/6002#newcode832 src/profile-generator.cc:832: static void DeleteHeapGraphEdge(HeapGraphEdge** p_edge) { the prefix p_ stands for parameter? If so I'd drop it. Same below. http://codereview.chromium.org/2722005/diff/5001/6002#newcode917 src/profile-generator.cc:917: int non_shared_total_size() { return non_shared_total_size_; } if we add 'const' this will break? If not, could you add it? http://codereview.chromium.org/2722005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
