http://codereview.chromium.org/2731007/diff/7002/17001 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/2731007/diff/7002/17001#newcode8274 src/arm/codegen-arm.cc:8274: __ sub(r7, r0, Operand(kHeapObjectTag)); On 2010/06/10 19:30:46, rodolph.perfetta wrote:
If you are not performing any FP operations then you are better off
loading the
values straight into r1 and r2. Moving value between FP and ARM
registers has a
cost.
Good point, thanks. I have changed it to directly load the values. http://codereview.chromium.org/2731007/diff/7002/17001#newcode8282 src/arm/codegen-arm.cc:8282: // h = (low ^ high); h ^= h >> 16; h ^= h
8; h = h & (cacheSize - 1);
On 2010/06/10 19:30:46, rodolph.perfetta wrote:
The mov is unnecessary simply use r1 as a source operand in the
following
instruction: eor(r3, r1, Operand(r2))
Done. http://codereview.chromium.org/2731007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
