Revision: 4840 Author: [email protected] Date: Fri Jun 11 00:06:51 2010 Log: Put code flushing behind flag - defaults to false.
Since we have an issue with code flusing on the trybots preventing us from pushing to chromium, a new flag for enabling code flushing, --flush_code, is introduced with this change (defaulting to false). Review URL: http://codereview.chromium.org/2734005 http://code.google.com/p/v8/source/detail?r=4840 Modified: /branches/bleeding_edge/src/flag-definitions.h /branches/bleeding_edge/src/heap.cc ======================================= --- /branches/bleeding_edge/src/flag-definitions.h Tue Jun 8 05:04:49 2010 +++ /branches/bleeding_edge/src/flag-definitions.h Fri Jun 11 00:06:51 2010 @@ -191,6 +191,8 @@ "print more details following each garbage collection") DEFINE_bool(collect_maps, true, "garbage collect maps from which no objects can be reached") +DEFINE_bool(flush_code, false, + "flush code that we expect not to use again before full gc") // v8.cc DEFINE_bool(use_idle_notification, true, ======================================= --- /branches/bleeding_edge/src/heap.cc Tue Jun 8 04:23:48 2010 +++ /branches/bleeding_edge/src/heap.cc Fri Jun 11 00:06:51 2010 @@ -605,8 +605,10 @@ EnsureFromSpaceIsCommitted(); if (collector == MARK_COMPACTOR) { - // Flush all potentially unused code. - FlushCode(); + if (FLAG_flush_code) { + // Flush all potentially unused code. + FlushCode(); + } // Perform mark-sweep with optional compaction. MarkCompact(tracer); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
