LGTM
http://codereview.chromium.org/2772004/diff/5001/6001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2772004/diff/5001/6001#newcode9288 src/arm/codegen-arm.cc:9288: __ ubfx(r3, r0, 2, 1); // Extract bit 2 of r0 to bit 0 of r3. Is ubfx supported on all platforms that we target? It seems to have been introduced in ARMv6T2, which is newer than the instruction list I have available. http://codereview.chromium.org/2772004/diff/5001/6001#newcode9289 src/arm/codegen-arm.cc:9289: __ tst(r3, r3); Why are these two instructions better than the one move they replace? http://codereview.chromium.org/2772004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
