All done, thanks a lot for review. And bit trick was really nice, thanks again.
yours, anton. On Fri, Jun 11, 2010 at 8:06 PM, <[email protected]> wrote: > LGTM with comments addressed. > > > http://codereview.chromium.org/2727009/diff/5001/6002 > File src/spaces-inl.h (right): > > http://codereview.chromium.org/2727009/diff/5001/6002#newcode166 > src/spaces-inl.h:166: if (!result) result = start_mask | end_mask; > result == 0 instead? > > a small comment about why we check result == 0 here might be handy > (start can be greater than end) > > http://codereview.chromium.org/2727009/diff/5001/6002#newcode179 > src/spaces-inl.h:179: > One more empty line here. > > http://codereview.chromium.org/2727009/show > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
