Looks sane enough to me. Disclaimer: I've never really looked at the v8 code.
On Fri, Jun 11, 2010 at 11:09 AM, <[email protected]> wrote: > Reviewers: Nico, Mads Ager, > > Message: > This part is (hopefully obviously) ok. > > Description: > Use this->Foo() in some places due to two-phase lookup. > > This is required by more strict compilers (Clang). > > Please review this at http://codereview.chromium.org/2037004/show > > SVN Base: http://v8.googlecode.com/svn/trunk/ > > Affected files: > M src/objects.cc > > > Index: src/objects.cc > =================================================================== > --- src/objects.cc (revision 4809) > +++ src/objects.cc (working copy) > @@ -8151,7 +8151,7 @@ > > template<typename Shape, typename Key> > Object* Dictionary<Shape, Key>::AtPut(Key key, Object* value) { > - int entry = FindEntry(key); > + int entry = this->FindEntry(key); > > // If the entry is present set the value; > if (entry != Dictionary<Shape, Key>::kNotFound) { > @@ -8176,7 +8176,7 @@ > Object* value, > PropertyDetails details) { > // Valdate key is absent. > - SLOW_ASSERT((FindEntry(key) == Dictionary<Shape, Key>::kNotFound)); > + SLOW_ASSERT((this->FindEntry(key) == Dictionary<Shape, > Key>::kNotFound)); > // Check whether the dictionary should be extended. > Object* obj = EnsureCapacity(1, key); > if (obj->IsFailure()) return obj; > @@ -8235,7 +8235,7 @@ > Object* value, > PropertyDetails details) { > UpdateMaxNumberKey(key); > - SLOW_ASSERT(FindEntry(key) == kNotFound); > + SLOW_ASSERT(this->FindEntry(key) == kNotFound); > return Add(key, value, details); > } > > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
