Rebased for current trunk, 3 static methods of TrascendentalCache were made instance methods of TrascendentalCacheData
http://codereview.chromium.org/2657004/diff/8001/9006 File src/heap.h (right): http://codereview.chromium.org/2657004/diff/8001/9006#newcode1824 src/heap.h:1824: class TranscendentalCache: public TranscendentalCacheTypes { TrascendentalCacheData is part of Isolate, it contains TrascendentalCache class instances for particular functions so there is no separate state. However, I transformed static members of TrascendentalCache to be instance methods of TrascendentalCacheData just to avoid current isolate instance lookup On 2010/06/07 17:18:02, Vitaly wrote:
Why not make TrascendentalCache itself a part of the isolate? This is
the
approach we're trying to use in this branch. Otherwise, some code that
already
knows the current isolate has to do repeated TLS reads to get to other
pieces of
state.
http://codereview.chromium.org/2657004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
