LGTM, with comments.
http://codereview.chromium.org/2826001/diff/1/2 File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/2826001/diff/1/2#newcode660 src/arm/assembler-arm.cc:660: // If the opcode is one with a complementary version and the complementary Shouldn't we have some test cases for this instruction transforming? I think extending test-disasm-arm.cc would do the trick. http://codereview.chromium.org/2826001/diff/1/5 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2826001/diff/1/5#newcode6899 src/arm/codegen-arm.cc:6899: __ Sbfx(r4, lhs_exponent, HeapNumber::kExponentShift, HeapNumber::kExponentBits); Long line. http://codereview.chromium.org/2826001/diff/1/5#newcode6911 src/arm/codegen-arm.cc:6911: __ Sbfx(r4, rhs_exponent, HeapNumber::kExponentShift, HeapNumber::kExponentBits); Long line. http://codereview.chromium.org/2826001/diff/1/5#newcode7634 src/arm/codegen-arm.cc:7634: __ Ubfx(scratch2, scratch, HeapNumber::kExponentShift, HeapNumber::kExponentBits); Long line. http://codereview.chromium.org/2826001/diff/1/10 File src/utils.h (right): http://codereview.chromium.org/2826001/diff/1/10#newcode52 src/utils.h:52: static inline int WhichPowerOf2(T x) { Shouldn't there be a test case for this? http://codereview.chromium.org/2826001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
