Reviewers: Vitaly, Dmitry Titov,
Message:
factory.cc will go away in a future CL; I've left it in for now to make
diffs
easier to read. This list touches a lot of files, but does so in a very
systematic way (usually Factory::foo => HEAP->foo or Factory::foo =>
HEAP->foo_handle).
http://codereview.chromium.org/2834002/diff/1/26
File src/handles.h (right):
http://codereview.chromium.org/2834002/diff/1/26#newcode36
src/handles.h:36:
There may be a better place to put the definition of Handle-- but it's
needed to appear before Heap.
Description:
[Isolates] Move Factory methods to Heap; make Heap members non-static.
Since the vast majority of Factory::* methods were simple wrappers around
Heap::* methods, I elected to remove the Factory class and instead add
these methods to Heap. This removes a potential added indirection cost
and simplifies things somewhat.
- Simple accessors (_value, _symbol, etc) from Factory gain the suffix
_handle (null_value_handle)
- Some methods on Heap had the same name as methods on Factory. These
included CopyFixedArray, CopyCode, NumberToString, LookupSymbol,
LookupAsciiSymbol. Renamed the Heap versions to include the suffix Raw;
renamed the Factory versions to include the suffix Handle.
Please review this at http://codereview.chromium.org/2834002/show
SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/
Affected files:
M src/accessors.cc
M src/api.h
M src/api.cc
M src/arm/codegen-arm.cc
M src/arm/fast-codegen-arm.cc
M src/arm/regexp-macro-assembler-arm.cc
M src/assembler.cc
M src/ast.h
M src/bootstrapper.cc
M src/builtins.cc
M src/code-stubs.cc
M src/codegen.cc
M src/compiler.cc
M src/conversions.cc
M src/debug.h
M src/debug.cc
M src/execution.cc
D src/factory.h
M src/factory.cc
M src/flow-graph.cc
M src/full-codegen.cc
M src/func-name-inferrer.h
M src/func-name-inferrer.cc
M src/handles.h
M src/handles.cc
M src/heap.h
M src/heap.cc
M src/ia32/builtins-ia32.cc
M src/ia32/codegen-ia32.cc
M src/ia32/fast-codegen-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/ic-ia32.cc
M src/ia32/macro-assembler-ia32.cc
M src/ia32/regexp-macro-assembler-ia32.cc
M src/ia32/stub-cache-ia32.cc
M src/ia32/virtual-frame-ia32.cc
M src/ic.cc
M src/jsregexp.cc
M src/liveedit.cc
M src/messages.cc
M src/objects-inl.h
M src/objects.cc
M src/parser.cc
M src/property.h
M src/rewriter.cc
M src/runtime.cc
M src/scopeinfo.cc
M src/scopes.h
M src/scopes.cc
M src/string-stream.cc
M src/stub-cache.cc
M src/top.cc
M src/variables.h
M src/x64/builtins-x64.cc
M src/x64/codegen-x64.cc
M src/x64/fast-codegen-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/ic-x64.cc
M src/x64/macro-assembler-x64.cc
M src/x64/regexp-macro-assembler-x64.cc
M src/x64/stub-cache-x64.cc
M src/x64/virtual-frame-x64.cc
M test/cctest/test-alloc.cc
M test/cctest/test-api.cc
M test/cctest/test-assembler-arm.cc
M test/cctest/test-assembler-ia32.cc
M test/cctest/test-assembler-x64.cc
M test/cctest/test-compiler.cc
M test/cctest/test-cpu-profiler.cc
M test/cctest/test-debug.cc
M test/cctest/test-disasm-ia32.cc
M test/cctest/test-func-name-inference.cc
M test/cctest/test-heap-profiler.cc
M test/cctest/test-heap.cc
M test/cctest/test-log-stack-tracer.cc
M test/cctest/test-macro-assembler-x64.cc
M test/cctest/test-mark-compact.cc
M test/cctest/test-regexp.cc
M test/cctest/test-serialize.cc
M test/cctest/test-strings.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
