I'm not quite sure what you mean wrt the reinterpret_cast. Do we keep a Factory* and a Heap* both inside Isolate but have them point to the same runtime object? Is this done elsewhere in the code? Will it interfere with compiler optimizations? Would it be better to rename the methods that can cause GC rather than placing them into a different facade class?
On Tue, Jun 15, 2010 at 9:47 AM, <[email protected]> wrote: > Luke, > > There's a clear separation between Heap and Factory. The former doesn't > handle > allocation failures and operates on raw pointers, the latter can trigger GC > and > operates on handles. I think it's better to keep the separation. If you're > worried about performance implications just reintepret_cast<Heap*>(this) in > Factory methods. > > > Thanks, > Vitaly > > > http://codereview.chromium.org/2834002/show > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
