LGTM with comments.
-- Vitaly http://codereview.chromium.org/2834004/diff/34001/35002 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/2834004/diff/34001/35002#newcode489 src/arm/assembler-arm.h:489: bool IsSupported(CpuFeature f) { This should be a const function. http://codereview.chromium.org/2834004/diff/34001/35002#newcode495 src/arm/assembler-arm.h:495: bool IsEnabled(CpuFeature f) { Ditto. http://codereview.chromium.org/2834004/diff/34001/35002#newcode504 src/arm/assembler-arm.h:504: : cpu_features_(Isolate::Current()->cpu_features()) { For debugging purposes save a pointer to the current isolate and assert that it is still current in the destructor. http://codereview.chromium.org/2834004/diff/34001/35009 File src/ia32/assembler-ia32.h (right): http://codereview.chromium.org/2834004/diff/34001/35009#newcode372 src/ia32/assembler-ia32.h:372: bool IsSupported(CpuFeature f) { See above. http://codereview.chromium.org/2834004/diff/34001/35009#newcode380 src/ia32/assembler-ia32.h:380: bool IsEnabled(CpuFeature f) { See above. http://codereview.chromium.org/2834004/diff/34001/35009#newcode388 src/ia32/assembler-ia32.h:388: : cpu_features_(Isolate::Current()->cpu_features()) { See above. http://codereview.chromium.org/2834004/diff/34001/35017 File src/isolate.cc (right): http://codereview.chromium.org/2834004/diff/34001/35017#newcode121 src/isolate.cc:121: Delete cpu_features? http://codereview.chromium.org/2834004/diff/34001/35020 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/2834004/diff/34001/35020#newcode346 src/x64/assembler-x64.h:346: bool IsSupported(CpuFeature f) { See above. http://codereview.chromium.org/2834004/diff/34001/35020#newcode355 src/x64/assembler-x64.h:355: bool IsEnabled(CpuFeature f) { See above. http://codereview.chromium.org/2834004/diff/34001/35020#newcode363 src/x64/assembler-x64.h:363: : cpu_features_(Isolate::Current()->cpu_features()) { See above. http://codereview.chromium.org/2834004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
