Otherwise, looks good.
Thanks, Vitaly http://codereview.chromium.org/2799008/diff/1/8 File src/scanner.h (right): http://codereview.chromium.org/2799008/diff/1/8#newcode400 src/scanner.h:400: ScannerCharacterClasses& scanner_character_classes_; Non-const references are very rare and are discouraged. Either switch to const reference (and mark some parts of the predicates as "mutable") or to pointer. nit: "scanner_" prefix on a member of Scanner class seems redundant. http://codereview.chromium.org/2799008/diff/1/8#newcode493 src/scanner.h:493: unibrow::Predicate<IdentifierStart, 128> kIsIdentifierStart; These are not static constants so should be named like_this or better yet we should have accessors for them. http://codereview.chromium.org/2799008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
