LGTM
http://codereview.chromium.org/2845003/diff/1/4 File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/2845003/diff/1/4#newcode113 src/arm/full-codegen-arm.cc:113: // registers, so we have use a third register to avoid third and fourth http://codereview.chromium.org/2845003/diff/1/4#newcode669 src/arm/full-codegen-arm.cc:669: __ RecordWrite(scratch1, Operand(Context::SlotOffset(dst->index())), We prefer either all on one line, or if that's not possible, one argument per line. http://codereview.chromium.org/2845003/diff/1/8 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/2845003/diff/1/8#newcode339 src/arm/stub-cache-arm.cc:339: // Pass the value being stored in the now unused name_reg. Comment needs updating here. http://codereview.chromium.org/2845003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
