Status: New
Owner: ----

New issue 739 by [email protected]: -Wextra warning in v8 (and possible bug)
http://code.google.com/p/v8/issues/detail?id=739

We're trying to turn on -Wextra in for Chromium on the Mac. All the core Chromium code is now clean, so we're down to a half dozen hits in WebKit and v8. The v8 hits are:

src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: In static member function 'static v8::Handle<v8::Value> WebCore::V8SQLResultSetRowList::itemCallback(const v8::Arguments&)': src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:59: warning: comparison of unsigned expression < 0 is always false

Is putting a signed value into an unsigned and then checking for < 0. Dropping the check would fix the warning, but the sign drop could be an real issue.


src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/npruntime.cpp: In function 'void _NPN_DeallocateObject(NPObject*)': src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/npruntime.cpp:299: warning: comparison of unsigned expression >= 0 is always true

This is an assert for npObject->referenceCount being >= 0, but since referenceCount appears to be an uint32, the assert can probably just be dropped.


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to