Reviewers: ,
http://codereview.chromium.org/2866008/diff/5002/26016 File src/contexts.h (right): http://codereview.chromium.org/2866008/diff/5002/26016#newcode263 src/contexts.h:263: inline bool has_out_of_memory(); Moved the implementation of these to isolate.h to fix a vertical dependency issue. http://codereview.chromium.org/2866008/diff/5002/26035 File src/isolate.cc (right): http://codereview.chromium.org/2866008/diff/5002/26035#newcode238 src/isolate.cc:238: void Isolate::TearDownAndRecreateGlobalIsolate() { This gets called from internal::V8::TearDown() rather than simply destroying the global isolate (just in case someone expects one of the previously-static objects to still be around after V8 goes away). Description: [Isolates] Move contents of Top into Isolate. - Interesting changes are in top.cc, isolate.cc, isolate.h. - Moved Handle from handles.h to isolate.h (vertical dependency problem). - Other changes are textual replacement of Top:: with Isolate::Current()->. - The code in top.cc belongs in isolate.cc. I have left it in the former temporarily to make reviewing this CL easier. I can move the code before committing this CL or I can move it in a CL following this one (should it be committed). Please review this at http://codereview.chromium.org/2866008/show SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/ Affected files: M include/v8.h M src/accessors.cc M src/api.cc M src/arm/codegen-arm.cc M src/arm/full-codegen-arm.cc M src/arm/macro-assembler-arm.cc M src/arm/regexp-macro-assembler-arm.cc M src/arm/stub-cache-arm.cc M src/assembler.h M src/assembler.cc M src/bootstrapper.cc M src/builtins.cc M src/checks.cc M src/codegen.cc M src/compiler.cc M src/contexts.h M src/debug.h M src/debug.cc M src/execution.cc M src/factory.cc M src/fast-codegen.cc M src/frames.h M src/frames.cc M src/full-codegen.cc M src/handles.h M src/handles.cc M src/heap.cc M src/ia32/codegen-ia32.cc M src/ia32/fast-codegen-ia32.cc M src/ia32/full-codegen-ia32.cc M src/ia32/macro-assembler-ia32.cc M src/ia32/regexp-macro-assembler-ia32.cc M src/ia32/stub-cache-ia32.cc M src/ic.cc M src/isolate.h M src/isolate.cc M src/jsregexp.cc M src/liveedit.cc M src/log.cc M src/messages.cc M src/messages.js M src/mips/codegen-mips.cc M src/mips/macro-assembler-mips.cc M src/objects.h M src/objects.cc M src/parser.cc M src/platform-linux.cc M src/regexp-macro-assembler.cc M src/regexp-stack.cc M src/runtime.cc M src/serialize.cc M src/stub-cache.cc D src/top.h M src/top.cc M src/v8.cc M src/v8threads.cc M src/x64/codegen-x64.cc M src/x64/full-codegen-x64.cc M src/x64/macro-assembler-x64.cc M src/x64/regexp-macro-assembler-x64.cc M src/x64/stub-cache-x64.cc M test/cctest/test-alloc.cc M test/cctest/test-api.cc M test/cctest/test-compiler.cc M test/cctest/test-debug.cc M test/cctest/test-disasm-ia32.cc M test/cctest/test-heap.cc M test/cctest/test-log-stack-tracer.cc M test/cctest/test-mark-compact.cc M test/cctest/test-regexp.cc M test/cctest/test-serialize.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
