3 small nits.
http://codereview.chromium.org/2860009/diff/4001/5001 File src/isolate.cc (right): http://codereview.chromium.org/2860009/diff/4001/5001#newcode55 src/isolate.cc:55: 2 empty lines before #endif could be removed. http://codereview.chromium.org/2860009/diff/4001/5001#newcode102 src/isolate.cc:102: Thread::SetThreadLocal(global_isolate_key_, NULL); Why is this needed? It's NULL by default. http://codereview.chromium.org/2860009/diff/4001/5002 File src/isolate.h (right): http://codereview.chromium.org/2860009/diff/4001/5002#newcode162 src/isolate.h:162: isolate = reinterpret_cast<Isolate*>( InitThreadForGlobalIsolate could simply return an isolate pointer, so these 2 lines could be removed. http://codereview.chromium.org/2860009/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
